Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Add check to see if WooCommerce is active before initializing anything. #100

Closed
claudiulodro opened this issue Jul 23, 2018 · 3 comments
Closed

Add check to see if WooCommerce is active before initializing anything. #100

claudiulodro opened this issue Jul 23, 2018 · 3 comments
Labels
type: bug The issue/PR concerns a confirmed bug.
Milestone
1.1.1

Comments

@claudiulodro
Copy link
Contributor

See WordPress/gutenberg#7423 (comment) for the error that is displayed when the plugin is active without WooCommerce active.
@claudiulodro claudiulodro added the type: bug The issue/PR concerns a confirmed bug. label Jul 23, 2018
@claudiulodro claudiulodro mentioned this issue Jul 23, 2018
Closed
@claudiosanches
Copy link
Contributor

Seems like we already only this plugin only in woocommerce_loaded: https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/master/woocommerce-gutenberg-products-block.php#L22-L30

@claudiulodro
Copy link
Contributor Author

This one calls wc_get_theme_support and loads even if WC isn't loaded. It just needs a small change.

This issue won't be a problem once this is merged into core. :P

@claudiulodro claudiulodro added this to the 1.1.1 milestone Aug 7, 2018
@robertdevore robertdevore mentioned this issue Aug 11, 2018
Closed
@claudiulodro
Copy link
Contributor Author

See 341bb00

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@claudiosanches @claudiulodro