Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Woo POS][non-simple products] Add tests for Variations data source and remove virtual filtering #13189

Closed
AnirudhBhat opened this issue Dec 23, 2024 · 1 comment · Fixed by #13190
Closed

[Woo POS][non-simple products] Add tests for Variations data source and remove virtual filtering #13189

AnirudhBhat opened this issue Dec 23, 2024 · 1 comment · Fixed by #13190
Assignees
@AnirudhBhat
Labels
feature: point of sale POS project type: task An internally driven task.
Milestone
21.4 ❄️

Comments

@AnirudhBhat
Copy link
Contributor

The objective of this task is to enhance test coverage by adding unit tests for the WooPosVariationsDataSource class. Additionally, the filtering logic for variations will be moved into this class. As part of this task, virtual variations will also be included, aligning with the ongoing discussion.
@AnirudhBhat AnirudhBhat added feature: point of sale POS project type: task An internally driven task. labels Dec 23, 2024
@AnirudhBhat AnirudhBhat added this to the 21.4 milestone Dec 23, 2024
@AnirudhBhat AnirudhBhat self-assigned this Dec 23, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@AnirudhBhat AnirudhBhat mentioned this issue Dec 23, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnirudhBhat AnirudhBhat

Labels
feature: point of sale POS project type: task An internally driven task.
Projects
None yet
Milestone
21.4 ❄️
2 participants
@AnirudhBhat @dangermattic