Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jest tests for Set up paid ads flow #2579

Closed
Tracked by #2459
joemcgill opened this issue Sep 4, 2024 · 2 comments
Closed
Tracked by #2459

Update Jest tests for Set up paid ads flow #2579

joemcgill opened this issue Sep 4, 2024 · 2 comments

Comments

@joemcgill
Copy link
Collaborator

joemcgill commented Sep 4, 2024

Caution

This is blocked by #2534, #2535, and #2536.

As a follow-up to the changes to streamline the paid ads flow defined in #2460, The related Jest tests will need to be updated once changes from the following issues are completed:

Acceptance criteria

Implementation details

This work should branch from the feature/2460-simplify-paid-ads-setup branch once each of the related issues listed in the overview of this ticket have been merged.

There is an AdsStepper test at js/src/setup-ads/ads-stepper/index.test.js that is currently failing.

@joemcgill joemcgill self-assigned this Sep 4, 2024
@joemcgill joemcgill added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Sep 4, 2024
@joemcgill joemcgill assigned kt-12 and unassigned joemcgill Sep 6, 2024
@joemcgill joemcgill mentioned this issue Sep 9, 2024
5 tasks
@joemcgill joemcgill assigned asvinb and unassigned kt-12 Oct 16, 2024
@asvinb
Copy link
Collaborator

asvinb commented Oct 17, 2024

@joemcgill @kt-12 The failing test was fixed in the following PR:
https://github.com/woocommerce/google-listings-and-ads/pull/2623/files#diff-c10ae52d5079fec4d79e7e3a503fd239e7c34f2f23567d3ed563dc818cf6cee0R42

I don't think there is anything else to do here. Furthermore, all tests pass on the feature/2459-campaign-creation-flow branch.

@asvinb asvinb assigned joemcgill and unassigned asvinb Oct 17, 2024
@joemcgill
Copy link
Collaborator Author

joemcgill commented Oct 17, 2024

Closing this as redundant now that this has been addressed in #2595 and #2632.

@joemcgill joemcgill removed their assignment Oct 25, 2024
@joemcgill joemcgill removed the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants