Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to get the exact error reason for the failed phone number verification request #1998

Closed
eason9487 opened this issue Jun 23, 2023 · 1 comment
Labels
status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: enhancement The issue is a request for an enhancement.

Comments

@eason9487
Copy link
Member

eason9487 commented Jun 23, 2023

Describe the bug:

It's a follow-up for us to occasionally revisit if the exact error reason is returned in the future.

Originally, if a phone number verification request fails, the reason field in the response body provides a clear code. For example, "rateLimitExceeded".

However, currently, Google's Content API for Shopping returns unclear reason, making it impossible to distinguish the actual cause of the error.

1

On GLA side, the response body of API results in:

{
  "message": "Internal error",
  "reason":  "backendError"
}

Steps to reproduce:

  1. Go to the phone number editing page: /wp-admin/admin.php?page=wc-admin&subpath=%2Fedit-phone-number&path=%2Fgoogle%2Fsettings
  2. Open the Network tab of browser DevTool.
  3. Trigger an API failure by one of these methods
    • Request verification with an invalid phone number: +31 111111111
    • Request verification with the same phone number within an hour six times.
  4. Inspect the result of gla/mc/phone-verification/request on the Network tab.

If someday the reason value is "rateLimitExceeded" or "badRequest" and the message is clearer, maybe then this issue can be solved.

Expected behavior:

Show the exact error reason for the failed phone number verification request.

Actual behavior:

Unable to get the exact error reason for the failed phone number verification request.

Additional details:

Found this issue while working on #1101

@eason9487 eason9487 added type: enhancement The issue is a request for an enhancement. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. labels Jun 23, 2023
@mikkamp
Copy link
Contributor

mikkamp commented Nov 14, 2024

Phone number verification is being removed in #2653 so I'm closing this issue as no longer applicable.

@mikkamp mikkamp closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants