Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed condition on cache expiration #163

Merged
merged 1 commit into from
May 14, 2018
Merged

Conversation

mpatafio
Copy link

The condition on the expiration is wrong, it doesn't work as described in the documentation.
given a source.expiration = undefined

!!!source.expiration -> true
Boolean(source.expiration) -> false

@wonday wonday merged commit 7e124d9 into wonday:master May 14, 2018
@wonday
Copy link
Owner

wonday commented May 14, 2018

@mpatafio You are right, thank you.

@wonday
Copy link
Owner

wonday commented May 24, 2018

@mpatafio this PR still have problem.
if you set an expiration, it will reload every time. do not use cache.
I had modified again and commit to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants