Fix of a problem with invariant 4 in the qtreetbl #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent the problem with violation of the rule: "If a node is red, then both its children are black"
wolkykim
reviewed
Apr 4, 2019
src/containers/qtreetbl.c
Outdated
| @@ -1050,6 +1195,11 @@ static qtreetbl_obj_t *put_obj(qtreetbl_t *tbl, qtreetbl_obj_t *obj, | |||
| if (is_red(obj->left) && is_red(obj->left->left)) { | |||
| obj = rotate_right(obj); | |||
| } | |||
|
|
|||
| // split 4-nodes on the way up. | |||
| /*if (is_red(obj->left) && is_red(obj->right)) { | |||
There was a problem hiding this comment.
can we remove this if this is not needed?
There was a problem hiding this comment.
I removed these comments in the last commit.
|
thank you for the update. left a minor comment. |
|
Thanks I am reviewing the change.
…On Sun, Apr 7, 2019, 4:38 AM darmar-lt ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/containers/qtreetbl.c
<#66 (comment)>:
> @@ -1050,6 +1195,11 @@ static qtreetbl_obj_t *put_obj(qtreetbl_t *tbl, qtreetbl_obj_t *obj,
if (is_red(obj->left) && is_red(obj->left->left)) {
obj = rotate_right(obj);
}
+
+ // split 4-nodes on the way up.
+ /*if (is_red(obj->left) && is_red(obj->right)) {
I removed these comments in the last commit.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#66 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGioMSkJ2CoFe8eRGEoNxooE6FqT0Faoks5vedi0gaJpZM4cUWLX>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch ads a test case for the invariant 4 in the qtreetbl and fixes the problem.