qtreetbl improvements #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strohsnow can you please review this change? |
strohsnow
approved these changes
Jul 21, 2023
strohsnow
approved these changes
Jul 21, 2023
strohsnow
approved these changes
Jul 22, 2023
wolkykim
commented
Jul 24, 2023
src/containers/qtreetbl.c
Outdated
| print_node(obj->right, out, &branch, true); | ||
|
|
||
| print_branch(prev, out); | ||
| if (prev != NULL) { | ||
| fprintf(out, "%s", (right) ? " ┌──" : " └──"); | ||
| fprintf(out, "%s%s", right ? "┌──" : "└──", obj->red ? "[" : "─"); |
There was a problem hiding this comment.
Now no leading space at all 👍
There was a problem hiding this comment.
Yeah, I think now it looks cleaner
strohsnow
approved these changes
Jul 25, 2023
strohsnow
approved these changes
Jul 25, 2023
strohsnow
approved these changes
Jul 26, 2023
|
Closing the branch following the merge. Please work on a new branch for upcoming changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working branch for qtreetbl update: