Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcp_inspect verbosity levels change #18

Closed
kevinlondon opened this issue Oct 23, 2013 · 4 comments
Closed

dcp_inspect verbosity levels change #18

kevinlondon opened this issue Oct 23, 2013 · 4 comments

Comments

@kevinlondon
Copy link

I noticed from the code that dcp_inspect sets the log level to only show the information that you have specified and sets the other flags to false. Could it be changed to include information from the level you specify and higher log levels?

Here's how I might see the order of log levels from lowest to highest:
debug, cr, hints, cpl, info, errors

As such, setting to to "info" would include errors and setting it to "hints" would include all info but debug and cr. Does that make sense? I can submit a sample patch.

@wolfgangw
Copy link
Owner

Makes sense, yes. Instead of replacing the current mechanism I'd prefer some added verbosity monikers to do what you need, though. I'm having a terrible thought: -v, -vv, -vvv, ...

Or: How about we allow a list of monikers, like -v cpl,errors,...?

@kevinlondon
Copy link
Author

Yes, I think the list of monikers idea is probably the way to go as opposed to the -vv, although I would be okay with that option as well. I am personally interested in a combination of info and errors, the other categories do not interest me as much.

@wolfgangw
Copy link
Owner

Done. Saying e.g. -v errors,info will do what you want. See latest version (v1.2013.11.27) and let me know whether it works for you.

And thanks for suggesting the feature. It's much better with this.

@kevinlondon
Copy link
Author

Thanks for updating it! I appreciate the help and I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants