Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second copy of pdfjs #927

Closed
wojtekmaj opened this issue Jan 20, 2022 · 5 comments
Closed

Second copy of pdfjs #927

wojtekmaj opened this issue Jan 20, 2022 · 5 comments
Labels
bug Something isn't working invalid This doesn't seem right stale

Comments

@wojtekmaj
Copy link
Owner

Thanks, that worked. I'm not sure why I have a second copy of pdfjs. Nowhere in my package.json I have it as a dependency or I have other packages that could install it as a dependency. I tried deleting my node_modules and reinstalling but it appeared again. I use npm so it's not a big issue.

Originally posted by @albireox in #912 (comment)

@wojtekmaj
Copy link
Owner Author

Share your package-lock.json or yarn.lock and we'll figure it out. If it's related to React-PDF we'll create another thread in order not to spam people.

Originally posted by @wojtekmaj in #912 (comment)

@wojtekmaj
Copy link
Owner Author

Here they are.

Archive.zip

Originally posted by @albireox in #912 (comment)

@wojtekmaj
Copy link
Owner Author

wojtekmaj commented Jan 20, 2022

Ah yes, that makes it clear.

"@types/react-pdf@npm:^5.0.9":
  version: 5.0.9
  resolution: "@types/react-pdf@npm:5.0.9"
  dependencies:
    "@types/react": "*"
    pdfjs-dist: ^2.10.377
"pdfjs-dist@npm:2.10.377":
  version: 2.10.377
  resolution: "pdfjs-dist@npm:2.10.377"
  peerDependencies:
    worker-loader: ^3.0.7

"pdfjs-dist@npm:^2.10.377":
  version: 2.12.313
  resolution: "pdfjs-dist@npm:2.12.313"
  peerDependencies:
    worker-loader: ^3.0.8
  peerDependenciesMeta:
    worker-loader:
      optional: true

so, it's actually a bug in @types/react-pdf, it may download a newer version of pdfjs-dist than used by React-PDF.

@wojtekmaj wojtekmaj added the question Further information is requested label Jan 20, 2022
@albireox
Copy link

Thanks for checking. That makes sense.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Apr 25, 2022
@wojtekmaj wojtekmaj added bug Something isn't working invalid This doesn't seem right and removed question Further information is requested labels Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right stale
Projects
None yet
Development

No branches or pull requests

2 participants