Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ux when manually entering numbers #49

Closed
frederikcreemers opened this issue Jan 26, 2019 · 1 comment
Closed

Better ux when manually entering numbers #49

frederikcreemers opened this issue Jan 26, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@frederikcreemers
Copy link

It would be cool if the component handled some cases better when manually entering the digits.

  • When a value has been typed, focus should automatically move to the next field
  • When I enter a 0 in the month or date field, the value is set to 00 as expected, but when I then enter a different digit, it is just appended, like 003. 3-digit numbers shouldn't be possible there.

I think the date time control shown in Chrome for input type="datetime-local" is a great example to model this component's behavior on. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local

Also notice how it automatically skips the month and year parts in the first example because the month and year of the maximum and minimum values have the same month and year.

I've looked over the code base to try and understand it to see if I could help and contribute to these improvements, but there's a lot to dig into. Still, I'll keep reading code :).

@wojtekmaj wojtekmaj added the enhancement New feature or request label Feb 2, 2019
@wojtekmaj wojtekmaj self-assigned this Jul 11, 2019
@wojtekmaj
Copy link
Owner

Hi,
this has been implemented in v2.5.0 (7a55aaa). Go check it out! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants