-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calender doesn't automatically close when entering a time #355
Comments
Another thing I noticed is that when I start entering the time first and then go to the other input fields with |
Hi @Rixtho, I have the same issue. After some investigation, I found that the issue comes from the following check: b753ffa#diff-736e0c388d54290d557a9c5ce11afc2623157a4641476336c30bb276944f60e5R189; namely, when the calendar is already opened, it won't open the clock, and vice-versa. This behaviour seems to have been introduced ~2 months ago. Since this is working properly on the demo, my assumption is that this version of this code hasn't been deployed on the demo. My assumption for why these changes were made is that by adding these extra checks for |
I've created a PR (above) for the behaviour of the calendar and clock not switching between each other as a user focuses different inputs. If a maintainer could have a look, it would be greatly appreciated ❤️ |
Fixed in #381. |
I use the date-time picker without the clock pop-up. When I click the year/month/day input field to start entering a date the calendar pop-up also opens which is expected behaviour. But when I enter the time at the end the pop-up should close again. It doesn't provide any value when I enter the time and it might even cover up other elements.
The text was updated successfully, but these errors were encountered: