Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to read requires_python from a project's settings #384

Open
brettcannon opened this issue Feb 10, 2021 · 3 comments
Open

Provide a way to read requires_python from a project's settings #384

brettcannon opened this issue Feb 10, 2021 · 3 comments

Comments

@brettcannon
Copy link
Contributor

How would this feature be useful?
Instead of having to specify what versions of Python are supported both in project metadata and in my noxfile.py , read it from the project metadata to infer what versions are supported.

This may require PEP 621 to gain traction before it's feasible.

Describe the solution you'd like
Some way to say, "use requires_python to know what versions of Python are considered supported".

Describe alternatives you've considered

  • Script to generate my noxfile.py based on my requires_python metadata.
  • Module to provide a decorator for a session.
@vaneseltine
Copy link
Contributor

I don't have an immediate solution, but I do have some thoughts on this.

The easy way (classifiers)

The way I address this for my own projects is with a very basic function that scrapes the PyPI trove classifiers, like:

def supported_pythons(classifiers_file=Path("setup.cfg")):
    """
    Parse all supported Python classifiers from setup.cfg
    """
    pattern = re.compile(r"Programming Language :: Python :: ([0-9]+\.[0-9.]+)")
    return pattern.findall(classifiers_file.read_text())

That covers only minor versions, of course, but it feeds nicely into @nox.session(python=supported_pythons())

It would probably be more correct way here to use setuptools/distutils to pull the classifiers? One could in the same manner pull requires_python...

The trickier way (requires_python)

However, requires_python can get a lot hairier -- e.g., Requires-Python: ">2.7,!=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*" -- allowing PEP 345 conditionals and then all the myriad PEP 440 version specs. I'm assuming there is some way in setuptools/distutils to parse those out and get a boolean for whether python executable X is valid under requires_python Y.

For nox, though, python= is implemented as more of a guess and check (see virtualenv.py). Call the appropriate version of the executable for that system; if that doesn't work, then skip that version and let the user know.

It seems to me that to properly handle requires_python nox would instead want to collate a list of all available system Pythons, then filter them based on that list.

@mayeut
Copy link
Contributor

mayeut commented May 8, 2022

cibuildwheel does a similar thing which might be interesting here:

@henryiii
Copy link
Collaborator

Mostly supported in #877. Could add checking each version for validity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants