Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2021-0145: Potential unaligned read #233

Closed
github-actions bot opened this issue Apr 13, 2023 · 1 comment
Closed

RUSTSEC-2021-0145: Potential unaligned read #233

github-actions bot opened this issue Apr 13, 2023 · 1 comment

Comments

@github-actions
Copy link
Contributor

Potential unaligned read

Details
Status unsound
Package atty
Version 0.2.14
URL softprops/atty#50
Date 2021-07-04

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

atty is Unmaintained

A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

Last release of atty was almost 3 years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

  • is-terminal
  • std::io::IsTerminal nightly-only experimental

See advisory page for additional details.

@matheus23
Copy link
Member

$ cargo tree -i atty
atty v0.2.14
└── criterion v0.4.0
    [dev-dependencies]
    └── wnfs-bench v0.1.20 (/home/philipp/program/work/rs-wnfs/wnfs-bench)

criterion doesn't have a new version yet, and this vulnerability doesn't apply in our case: We don't use a custom global allocator, and finally, this is only a dev-dependency of a benchmark crate that we don't even publish. So I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant