Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstreaming into GTK? #43

Closed
Conan-Kudo opened this issue Aug 27, 2024 · 6 comments
Closed

Upstreaming into GTK? #43

Conan-Kudo opened this issue Aug 27, 2024 · 6 comments

Comments

@Conan-Kudo
Copy link

Have you considered upstreaming it into GTK proper? I briefly talked to @matthiasclasen about this yesterday and he didn't seem against the idea of having layer-shell supported in GTK itself.

@wmww
Copy link
Owner

wmww commented Sep 1, 2024

In the early development of the GTK3 version and then again when starting the GTK4 port myself and others who looked into it got a lot of pushback from GTK. Ultimately I concluded writing some shims and doing dynamic library hackery would be easier than winning arguments on IRC, so that's what I went with.

I'd be perfectly happy if this project was made irrelevant by upstream or somebody contributing to upstream, but I'm not going to dedicate any of my cycles to this.

@wmww wmww closed this as completed Sep 1, 2024
@wmww
Copy link
Owner

wmww commented Sep 1, 2024

See here and here for some of the history, though I'm not sure how much of what you'll find there is still relevant.

@ids1024
Copy link

ids1024 commented Sep 1, 2024

And #9, though that mainly just links the same things.

I think it would be possible to land the minimum necessary changes required to accommodate this in GTK. Though it's nontrivial. I'm not really working with GTK4 anymore, but if anyone's interested I can try to offer some suggestions from what I remember of this.

@wmww
Copy link
Owner

wmww commented Sep 1, 2024

Oh yeah, I looked for that issue but didn't see it for some reason. If anything were to be upstreamed, just doing enough API to allow for better 3rd party surface types seems like the best way to do it to me.

@ids1024
Copy link

ids1024 commented Sep 1, 2024

Yeah. It would also be good to support ext_session_lock_surface_v1 and other possible surface types. And it might not make sense to support those all in GTK. But a non-hacky way for libraries to do it would be nice.

@Conan-Kudo
Copy link
Author

When I talked to @matthiasclasen about it, he seemed like he wanted it directly supported in GTK in some way rather than having GTK overlay modules like this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants