Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Husky hooks not working #436

Open
romucci opened this issue Oct 26, 2018 · 1 comment
Open

Husky hooks not working #436

romucci opened this issue Oct 26, 2018 · 1 comment

Comments

@romucci
Copy link

romucci commented Oct 26, 2018

Whenever I use this way of creating the react app, and then install husky, the hooks don't seem to work!

Is there something I am doing wrong? :D!

{
  "name": "learning-typescript",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "react": "^16.6.0",
    "react-dom": "^16.6.0",
    "react-scripts-ts": "3.1.0"
  },
  "scripts": {
    "start": "react-scripts-ts start",
    "build": "react-scripts-ts build",
    "test": "react-scripts-ts test --env=jsdom",
    "eject": "react-scripts-ts eject"
  },
  "devDependencies": {
    "@types/jest": "^23.3.7",
    "@types/node": "^10.12.0",
    "@types/react": "^16.4.18",
    "@types/react-dom": "^16.0.9",
    "husky": "^1.1.2",
    "typescript": "^3.1.3"
  },
  "husky": {
    "hooks": {
      "pre-commit": "npm test"
    }
  }
}
@DorianGrey
Copy link
Collaborator

DorianGrey commented Nov 1, 2018

This should be the correct configuration. I cannot reproduce this issue, either. Do you have an exemplary repository illustrating this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants