Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

.mjs support #259

Closed
vladinator1000 opened this issue Feb 17, 2018 · 4 comments
Closed

.mjs support #259

vladinator1000 opened this issue Feb 17, 2018 · 4 comments

Comments

@vladinator1000
Copy link

Hi guys, any chance this PR will make its way in sometime soon?

@mbrowne
Copy link

mbrowne commented Mar 6, 2018

There is indeed an issue with .mjs files...the latest release candidate version of react-apollo (2.1.0-rc.1), which now uses .mjs files if the version of node supports it, is now broken when using create-react-app-typescript. But it appears that the above PR was already merged -- both into the original create-react-app and this repo -- so there must be some other issue. In the case of react-apollo, it can be resolved in the meantime by removing all mentions of .mjs from webpack.config.dev.js (Apollo then falls back to the .js files), but obviously this is not ideal...

@mbrowne
Copy link

mbrowne commented Mar 21, 2018

The react-apollo issue appears to be solved:
apollographql/react-apollo#1750

@mbrowne
Copy link

mbrowne commented Mar 27, 2018

Related: #287. I think this issue can be closed; once #287 is fixed then .mjs files should be working well across the board.

@DorianGrey
Copy link
Collaborator

Was already fixed in 2.15.1 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants