Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Way to remove data-test attributes for prod? #195

Closed
quantuminformation opened this issue Nov 22, 2017 · 2 comments
Closed

Way to remove data-test attributes for prod? #195

quantuminformation opened this issue Nov 22, 2017 · 2 comments

Comments

@quantuminformation
Copy link

quantuminformation commented Nov 22, 2017

What would need to be done to remove data-test attributes for prod? These are useful for testing.

For inspiration see https://github.com/oliviertassinari/babel-plugin-react-remove-properties

@bootstraponline
Copy link

I'm keeping the data-test attributes because otherwise there's no way to test prod. Probably a customization like this belongs in a fork since there's no way to serve both use cases. It'd also make the pipeline slower for people who don't need to remove attributes.

@DorianGrey
Copy link
Collaborator

I agree with @bootstraponline - this is out of scope for this fork, and we don't want to diverge too much from the original CRA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants