Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufr-to-bufr pipeline does not match on tsi #581

Closed
maaikelimper opened this issue Nov 22, 2023 · 1 comment
Closed

bufr-to-bufr pipeline does not match on tsi #581

maaikelimper opened this issue Nov 22, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@maaikelimper
Copy link
Collaborator

maaikelimper commented Nov 22, 2023

As reported by Iran, they have registered station wsi=0-364-0-40755 with tsi=40755 in their wis2box station metadata

image

But when they ingest data for this station it fails:
image

This is due to the get_valid_station-function in station.py ignoring the input tsi:
https://github.com/wmo-im/wis2box/blob/main/wis2box-management/wis2box/metadata/station.py#L356-L372

@efucile I'm trying to understand if we implemented this on purpose, to force users to encode correct wsi in their input-bufr ?

On the other hand the bufr-to-bufr pipeline is recreating the wis2box with the wsi provided from the station-metadata, so there is no reason to fail to bufr-ingestion for this.

@maaikelimper maaikelimper added the bug Something isn't working label Nov 22, 2023
@maaikelimper maaikelimper added this to the sprint-013 milestone Nov 22, 2023
@maaikelimper
Copy link
Collaborator Author

The same issue was reported by Barbados, it seems to be a common case, so I prepare a fix to allow the bufr-to-bufr pipeline to match on tsi and encode the wigos-station-identifier provided by the station metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants