Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table B 01: New BUFR descriptor for light source identifier #109

Closed
marijanacrepulja opened this issue Mar 25, 2022 · 7 comments · Fixed by #125
Closed

Table B 01: New BUFR descriptor for light source identifier #109

marijanacrepulja opened this issue Mar 25, 2022 · 7 comments · Fixed by #125
Assignees
Milestone

Comments

@marijanacrepulja
Copy link
Collaborator

marijanacrepulja commented Mar 25, 2022

Summary and purpose

ECMWF is proposing new BUFR descriptor for light source identifier.

Stakeholders

Marijana Crepulja, Antje Inness, Roberto Ribas (all from ECMWF)

Action proposed

The team is kindly asked to review and approve the contents for inclusion within the next update to the WMO Manual on Codes.

Discussions

ECMWF is preparing for assimilation of Altius ozone observations. In order to identify different light sources we need a new descriptor.

Detailed proposal

1. Add a new entry and corresponding note in the identification class of table B (0-01-145) and a new code table to describe light source

F X Y ELEMENT NAME UNIT SCALE REFERENCE VALUE DATA WITH (bits)
0-01-145 Light source identifier Numeric 0 -8 20

NOTE: Positive value corresponds to Hipparcos identifier, 0 is Sun, -2 is Venus, -4 is Mars, -5 is Jupiter, -6 is Saturn, -7 is Earth's moon, -8 is Bright limb

@marijanacrepulja marijanacrepulja self-assigned this Mar 25, 2022
@marijanacrepulja marijanacrepulja added this to the FT2022-2 milestone Mar 25, 2022
@amilan17
Copy link
Member

Re: https://github.com/wmo-im/CCT/wiki/Teleconference-26-and-28.4.2022

In progress, discussion over new descriptor and meaning of the values. Marijana to add explanatory note, linking to the Hipparcos catalogue.

@amilan17
Copy link
Member

https://github.com/wmo-im/CCT/wiki/Teleconference-18-and-19.5.2022 notes:

note is added in issue summary, change -7 to 'Earth's moon'

@amilan17
Copy link
Member

@marijanacrepulja please add the note and use temporary note ID: issue109

https://github.com/wmo-im/BUFR4/blob/issue109/notes/BUFRCREX_TableB_notes.csv

@marijanacrepulja
Copy link
Collaborator Author

@amilan17 I have added the note. Not sure if it is correct way of doing it. Could you please review and move to "Ready to FT " I am happy to add changes if need be. Thanks

It would be good we go through the process of adding the note at the meeting next week, so we all agree and know it.

@amilan17
Copy link
Member

amilan17 commented Jun 8, 2022

https://github.com/wmo-im/CCT/wiki/Teleconference-8.6.2022 notes:

@amilan17 validate for FT readiness

@amilan17 amilan17 linked a pull request Jun 9, 2022 that will close this issue
@amilan17
Copy link
Member

@marijanacrepulja I made some note revisions, does it still make sense? 

"In descriptor 0 01 145, the positive values correspond to Hipparcos identifiers where 0 is Sun, -2 is Venus, -4 is Mars, -5 is Jupiter, -6 is Saturn, -7 is Earth's moon, and -8 is Bright limb."

@marijanacrepulja
Copy link
Collaborator Author

@amilan17
"0 is Sun, -2 is Venus, -4 is Mars, -5 is Jupiter, -6 is Saturn, -7 is Earth's moon, and -8 is Bright limb" are not part of the Hipparcos identifiers. The Hipparcos Identifier is Star ID.

@amilan17 amilan17 moved this to Ready for FT Approval Procedure in BUFR4 Amendments Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants