Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails 7.2 #91

Closed
pkarjala opened this issue Aug 27, 2024 · 5 comments
Closed

Add support for Rails 7.2 #91

pkarjala opened this issue Aug 27, 2024 · 5 comments

Comments

@pkarjala
Copy link

Rails 7.2 is now released as of August 9th; when attempting to update an existing application and then install devise-otp, it will install Rails 7.1 instead due to compatibility issues listed with the gem.

$ bundle install
Fetching gem metadata from https://rubygems.org/.........
Resolving dependencies...
Could not find compatible versions

Because devise-otp < 0.3.0 depends on rails >= 3.2.6, < 5
  and devise-otp >= 0.3.0, < 0.5.0 depends on rails >= 7.0, < 7.1,
  devise-otp < 0.5.0 requires rails >= 3.2.6, < 5 OR >= 7.0, < 7.1.
And because devise-otp >= 0.5.0, < 0.6.0 depends on rails >= 7.0, < 7.2,
  devise-otp < 0.6.0 requires rails >= 3.2.6, < 5 OR >= 7.0, < 7.2.
So, because devise-otp >= 0.6.0 depends on rails >= 6.1, < 7.2
  and Gemfile depends on rails ~> 7.2,
  version solving has failed.
@n-rodriguez
Copy link
Contributor

@pkarjala hello! this has been fixed in PR #87

you can update your Gemfile to use master branch :

gem 'devise-otp', github: 'wmlele/devise-otp'

@n-rodriguez
Copy link
Contributor

@wmlele can you please cut a new release? thank you!

@n-rodriguez
Copy link
Contributor

n-rodriguez commented Aug 27, 2024

@wmlele @pkarjala actually there is an other error :

I have forced Rails version to 7.2.1 :

Could not find compatible versions

Because every version of devise-otp depends on rails >= 6.1, <= 7.2
  and Gemfile depends on rails ~> 7.2.1,
  devise-otp cannot be used.
So, because Gemfile depends on devise-otp >= 0,
  version solving has failed.

@n-rodriguez
Copy link
Contributor

I've made a PR for this issue : #92

@strzibny
Copy link
Collaborator

strzibny commented Sep 1, 2024

Merged.

@strzibny strzibny closed this as completed Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants