Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better pyproject.toml structure #115

Open
1 task done
wmalgadey opened this issue Dec 21, 2024 · 1 comment · May be fixed by #142
Open
1 task done

Better pyproject.toml structure #115

wmalgadey opened this issue Dec 21, 2024 · 1 comment · May be fixed by #142

Comments

@wmalgadey
Copy link
Owner

wmalgadey commented Dec 21, 2024

can't you put all dependencies in your pyproject.toml? You can provide production and optional dependencies (like for testings) and use "tags" to decide what to install. Here is an example.

In your case, requests is a dependency, while responses is a dev dependency, so you'll list it below project.optional-dependencies.

If you do it, we can remove the pip install -r requirements.txt step and just pip install -e '.[all]'.

Originally posted by @palazzem in #109 (comment)

  • removed requirements.txt
  • added all dependencies to pyproject.toml
  • make dependencies per task/job visible/installable
@inverse
Copy link

inverse commented Jan 1, 2025

What else would you change here? The dependencies aspect seems reasonable and dev group functional.

The pylint configuration seems quite verbose but not that familiar with that toolchain.

@wmalgadey wmalgadey linked a pull request Jan 2, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants