From c82a2e736fa4b6e85d53fa9f3ba554eac48d22eb Mon Sep 17 00:00:00 2001 From: Aleksa Sarai Date: Fri, 27 May 2016 13:26:21 +1000 Subject: [PATCH] MAINTAINERS: disallow self-LGTMs Apart from being a sign of respect to other maintainers, it also ensures that *all* pull requests get equal amounts of review -- no matter who wrote them. Maintainers should know better than to make broken patchsets, but it's also a sign of respect to the community that all pull requests have equal treatment. Signed-off-by: Aleksa Sarai --- MAINTAINERS_GUIDE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS_GUIDE.md b/MAINTAINERS_GUIDE.md index 67a8038..8f6f129 100644 --- a/MAINTAINERS_GUIDE.md +++ b/MAINTAINERS_GUIDE.md @@ -64,7 +64,9 @@ All decisions are pull requests, and the relevant maintainers make decisions by accepting or refusing the pull request. Review and acceptance by anyone is denoted by adding a comment in the pull request: `LGTM`. However, only currently listed `MAINTAINERS` are counted towards the required -two LGTMs. +two LGTMs. In addition, if a maintainer has created a pull request, they cannot +count toward the two LGTM rule (to ensure equal amounts of review for every pull +request, no matter who wrote it). Overall the maintainer system works because of mutual respect across the maintainers of the project. The maintainers trust one another to make decisions