Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If url schema in capital letters it wont work #9

Open
vladmiller opened this issue May 21, 2014 · 1 comment
Open

If url schema in capital letters it wont work #9

vladmiller opened this issue May 21, 2014 · 1 comment
Assignees
@wkcaj
Labels
bug

Comments

@vladmiller
Copy link

Whenever you have schema in capital letters it won't match with whitelisted schemas list

Example
HTTP://google.com

Most likely you can make schema and hostname lower case, but not query
@vladmiller vladmiller changed the title Schema in capital won't work If url schema in capital letters it wont work May 21, 2014
@wkcaj
Copy link
Owner

wkcaj commented May 21, 2014

Hey,

What I'll do is do a strtolower on the scheme before validation. For the hostname, it'll be tackled in Issue #7 which will cover changing the hostname matching.

Cheers,
Jack

@wkcaj wkcaj self-assigned this May 21, 2014
@wkcaj wkcaj added the bug label May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkcaj wkcaj

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wkcaj @vladmiller