Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When testing against whitelisted ip's, it only checks whether there is a valid whitelisted ip, and not whether there is an ip that doesn't match #17

Closed
hughdavenport opened this issue Nov 25, 2014 · 1 comment

Comments

@hughdavenport
Copy link

from https://github.com/fin1te/safecurl/blob/master/src/fin1te/SafeCurl/Url.php#L138

from my take on this, you can go have say whitelist of ('1.2.3.4'), and a host that resolves to ('4.3.2.1', '1.2.3.4'), and this check will set valid to true after checking the second ip, but the first is the one most likely to get used, and is not whitelisted.

I could be wrong, but my thinking is that all the ips should match something on the whitelist?

Cheers,

Hugh

@hughdavenport
Copy link
Author

dupe of #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant