Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Profile View #200

Closed
wants to merge 10 commits into from
Closed

feat: Profile View #200

wants to merge 10 commits into from

Conversation

GeorginaFraire
Copy link
Collaborator

What does this PR do?

  • Add a new view to display user information such as questions they asked, commented, and in the case of the admin, questions they answered.

Where should the reviewer start?

  • app/routes/profile.jsx
  • app/components/QuestionTable
  • app/components/Atoms/Table

How should this be manually tested?

  1. Login
  2. Go to the user image, open the menu and click on the profile picture
  3. 🎉

What are the relevant tickets?

(Link to issues, related PR, JIRA issues, etc.)
Closes #156

Screen.Recording.2023-03-15.at.15.42.42.mov

@GeorginaFraire GeorginaFraire marked this pull request as ready for review March 15, 2023 21:51
albertcastaned
albertcastaned reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@albertcastaned albertcastaned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it's intentional, I think maybe we should make the profile access more obvious for users?. It could be hidden unless someone clicks on their own image by accident. Maybe adding a new button in the profile dropdown?

@GeorginaFraire
Copy link
Collaborator Author

Unless it's intentional, I think maybe we should make the profile access more obvious for users?. It could be hidden unless someone clicks on their own image by accident. Maybe adding a new button in the profile dropdown?

Yeah! I will add a new option in the navbar.

albertcastaned
albertcastaned reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@albertcastaned albertcastaned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeorginaFraire Continued reviewing, left some more comments , will test locally next.

app/controllers/profile/questionsCreated.js Outdated Show resolved Hide resolved
app/controllers/profile/questionsCreated.js Outdated Show resolved Hide resolved
albertcastaned
albertcastaned approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@albertcastaned albertcastaned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@GeorginaFraire GeorginaFraire changed the title feat: Profile View. Profile View Mar 29, 2023
@GeorginaFraire GeorginaFraire changed the title Profile View feat: Profile View Mar 29, 2023
@GeorginaFraire GeorginaFraire deleted the feat/profile branch July 18, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carlos-Reyna Carlos-Reyna Carlos-Reyna approved these changes

@albertcastaned albertcastaned albertcastaned approved these changes

@amilcaralex97 amilcaralex97 Awaiting requested review from amilcaralex97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create profile view
3 participants
@GeorginaFraire @albertcastaned @Carlos-Reyna