Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] [iOS] TextInput focusing in componentDidMount broken in Overlays #4824

Closed
ItsNoHax opened this issue Mar 5, 2019 · 5 comments · Fixed by #5002
Closed

[Regression] [iOS] TextInput focusing in componentDidMount broken in Overlays #4824

ItsNoHax opened this issue Mar 5, 2019 · 5 comments · Fixed by #5002

Comments

@ItsNoHax
Copy link
Collaborator

ItsNoHax commented Mar 5, 2019

Issue Description

Regarding MR: #4778

It seems like that MR has caused some regression regarding TextInput focusing.
TextInputs with autoFocus prop or focusing in componentDidMount no longer work.

Steps to Reproduce / Code Snippets / Screenshots

Overlay with following code:

componentDidMount() {
  this.textInput.focus();
}

render() {
return (
 <TextInput
   ref={(ref) => { this.textInput = ref; }}
   ...otherProps
 />
)

or

render() {
return (
 <TextInput
   autoFocus
   ...otherProps
 />
)

Environment

  • React Native Navigation version: 2.13.1
  • React Native version: 0.57.8
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): ALL
@yogevbd
Copy link
Collaborator

yogevbd commented Apr 18, 2019

@ItsNoHax You can now make your overlay respond to keyboard events by passing overlay.handleKeyboardEvents: true option

@samahndev
Copy link

Hi @yogevbd - The issue where autoFocus on TextInput in Overlays which doesn't launch soft keyboard still seems to be an issue even on v4.0.3.

I did add overlay.handleKeyboardEvents: true option.

@cspicuzza
Copy link

RN: 0.61.5
RNN: 4.8.4

I'm having the same issue with <TextInput autoFocus> being ignored on showModal()

@zabojad
Copy link
Contributor

zabojad commented Nov 3, 2020

Same here :(
RNN 6.10.1
RN 0.63.3

@JasonXiang2014
Copy link
Contributor

Same here :(
RNN 7.8.4
RN 0.63.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants