From 9126ced3bd1e0d82d966f6b45f529ac876ecc9d8 Mon Sep 17 00:00:00 2001 From: Eli Sadaka <35779188+EliSadaka@users.noreply.github.com> Date: Mon, 1 Apr 2019 15:56:54 -0400 Subject: [PATCH] Do not setTag to bottomTabs if testId is null (#4935) Fixes #4812 --- .../reactnativenavigation/presentation/BottomTabPresenter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/android/app/src/main/java/com/reactnativenavigation/presentation/BottomTabPresenter.java b/lib/android/app/src/main/java/com/reactnativenavigation/presentation/BottomTabPresenter.java index 18b953d8be3..8502c4870e8 100644 --- a/lib/android/app/src/main/java/com/reactnativenavigation/presentation/BottomTabPresenter.java +++ b/lib/android/app/src/main/java/com/reactnativenavigation/presentation/BottomTabPresenter.java @@ -54,7 +54,7 @@ public void applyOptions() { bottomTabs.setTitleInactiveColor(i, tab.textColor.get(null)); bottomTabs.setTitleInactiveTextSizeInSp(i, tab.fontSize.hasValue() ? Float.valueOf(tab.fontSize.get()) : null); bottomTabs.setTitleActiveTextSizeInSp(i, tab.selectedFontSize.hasValue() ? Float.valueOf(tab.selectedFontSize.get()) : null); - bottomTabs.setTag(i, tab.testId.get(null)); + if (tab.testId.hasValue()) bottomTabs.setTag(i, tab.testId.get()); } }