-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0.0 is not working on android - height is not changing. #44
Comments
which RN version are you using? |
Thanks for looking at this. |
As i've mentioned in the other issue, auto-grow is now available out of the box in regular RN multiline text-inputs. so _handleNativeEvent is no longer necessary, we're not setting the height ourselves anymore. The reason we still keep using this component in modern RN versions is because of very specific native fixes that we added, which I don't know if you're even using or plan to use. I checked the example project and it auto-grows as expected on both Android and iOS, so I don't know why it is not working for you. Maybe some styles you applied are causing issues? Have you tried running the example project? |
Hi Artald, |
@artald may you please link us to the note in the react native release section ( https://github.com/facebook/react-native/releases )where it says they autogrow now. I can't find it, i was hoping to look at the related commits to see how they do it. |
Hi @Noitidart iOS support added on RN44 here and here. Android support was added on RN50 here |
Thank you sir very much especially for even giving me version numbers, and even linking me to it!! |
Seems like when using version 5.0.0 in Android the height is not changed when needed. In previous versions, I was using the fix at #28, but now, the method _handleNativeEvent doesn't exist.
This is so weird, the purpose of this lib is to grow automatically, and that's not working...
10x,
EyalS
The text was updated successfully, but these errors were encountered: