Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 is not working on android - height is not changing. #44

Closed
EyalSi opened this issue Jan 15, 2018 · 7 comments
Closed

5.0.0 is not working on android - height is not changing. #44

EyalSi opened this issue Jan 15, 2018 · 7 comments

Comments

@EyalSi
Copy link

EyalSi commented Jan 15, 2018

Seems like when using version 5.0.0 in Android the height is not changed when needed. In previous versions, I was using the fix at #28, but now, the method _handleNativeEvent doesn't exist.
This is so weird, the purpose of this lib is to grow automatically, and that's not working...
10x,
EyalS

@artald
Copy link
Collaborator

artald commented Jan 15, 2018

which RN version are you using?

@EyalSi
Copy link
Author

EyalSi commented Jan 15, 2018

Thanks for looking at this.
I'm using RN 0.52.0.

@artald
Copy link
Collaborator

artald commented Jan 16, 2018

As i've mentioned in the other issue, auto-grow is now available out of the box in regular RN multiline text-inputs. so _handleNativeEvent is no longer necessary, we're not setting the height ourselves anymore.

The reason we still keep using this component in modern RN versions is because of very specific native fixes that we added, which I don't know if you're even using or plan to use.

I checked the example project and it auto-grows as expected on both Android and iOS, so I don't know why it is not working for you.

Maybe some styles you applied are causing issues? Have you tried running the example project?

@EyalSi
Copy link
Author

EyalSi commented Jan 18, 2018

Hi Artald,
I've tried already removing all styles but had the same problem. Just moved back to the standard text input.
10x,
EyalS

@Noitidart
Copy link

@artald may you please link us to the note in the react native release section ( https://github.com/facebook/react-native/releases )where it says they autogrow now. I can't find it, i was hoping to look at the related commits to see how they do it.

@artald
Copy link
Collaborator

artald commented Jan 31, 2018

Hi @Noitidart

iOS support added on RN44 here and here. Android support was added on RN50 here

@artald artald closed this as completed Jan 31, 2018
@Noitidart
Copy link

Noitidart commented Feb 1, 2018

Thank you sir very much especially for even giving me version numbers, and even linking me to it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants