refactor(data_structures): avoid iterating twice over the same vector

Get the pkh and call `to_string` in the same `.map` instead of doing it in two different iterations.
witnet · Oct 18, 2023 · 7ab51a9 · 7ab51a9
1 parent 5a7c8b7
commit 7ab51a9
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/data_structures/src/superblock.rs b/data_structures/src/superblock.rs
@@ -163,8 +163,7 @@ impl SuperBlockVotesMempool {
             |mut acc, (superblock_hash, votes)| {
                 let pkhs: Vec<String> = votes
                     .iter()
-                    .map(|vote| vote.secp256k1_signature.public_key.pkh())
-                    .map(|pkh| pkh.to_string())
+                    .map(|vote| vote.secp256k1_signature.public_key.pkh().to_string())
                     .collect();
 
                 acc.push_str(&format!(