Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add charset note md/mdx pages #9757

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Add charset note md/mdx pages #9757

merged 5 commits into from
Oct 31, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 21, 2024

Description (required)

Add docs related to changes in withastro/astro#12231, particularly:

  • migration guide
  • notes in markdown layout section about charset behaviour

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.x. See astro PR withastro/astro#12231

@bluwy bluwy added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) 5.0.0-beta labels Oct 21, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 51bffde
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/672393605777ca00082a6d9d
😎 Deploy Preview https://deploy-preview-9757--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bluwy bluwy mentioned this pull request Oct 23, 2024
Merged
@sarah11918
Copy link
Member

@bluwy This was my thinking! You can make any corrections you like, otherwise, I'll assume this works!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Oct 23, 2024
@bluwy
Copy link
Member Author

bluwy commented Oct 24, 2024

Looks great! Thanks for updating it

@sarah11918 sarah11918 merged commit d05ee7c into 5.0.0-beta Oct 31, 2024
5 checks passed
@sarah11918 sarah11918 deleted the plt-1057-charset-utf-8 branch October 31, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

Assignees
No one assigned
Labels
5.0.0-beta add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @sarah11918