Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unflag hybrid output #7260

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Unflag hybrid output #7260

merged 2 commits into from
Jun 5, 2023

Conversation

natemoo-re
Copy link
Member

Changes

  • Accidentally merged Unflag hybrid output #7255 so this adds the code changes back
  • Follow-up to feat: hybrid output #6991
  • Stabilizes output: 'hybrid' by removing the experimental.hybridOutput flag
  • Refactors some internal code that checked for server || hybrid with a shared utility.

Testing

Existing tests should pass, experimental.hybridOutput flags have been removed from fixtures.

Docs

Config docs will be automatically updated.

@natemoo-re natemoo-re requested a review from a team as a code owner May 31, 2023 17:09
@changeset-bot
Copy link

changeset-bot bot commented May 31, 2023

🦋 Changeset detected

Latest commit: b84aabf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: minor Change triggers a `minor` release labels May 31, 2023
@github-actions
Copy link
Contributor

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for minor release.

@matthewp
Copy link
Contributor

Code looks good!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@natemoo-re natemoo-re dismissed matthewp’s stale review May 31, 2023 22:17

Covered by bot ☺️

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@natemoo-re natemoo-re force-pushed the feat/hybrid-unflag branch from 45c706c to b84aabf Compare June 5, 2023 17:29
@natemoo-re natemoo-re merged commit 39403c3 into main Jun 5, 2023
@natemoo-re natemoo-re deleted the feat/hybrid-unflag branch June 5, 2023 18:19
@astrobot-houston astrobot-houston mentioned this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants