From ad90896958906e7d96bd059506660c9ad9e228f4 Mon Sep 17 00:00:00 2001 From: Reece McDonald Date: Thu, 23 Feb 2023 17:14:48 -0600 Subject: [PATCH 1/2] [Lit] render DSD attributes based on `shadowRootOptions` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Changes - Update `@astrojs/lit`’s `server.js` to properly render elements with `delegatesFocus: false` set in their `shadowRootOptions`. - Logic is based on `@lit-labs/ssr` [latest implementation as found here](https://github.com/lit/lit/blob/b0c3f82ef0f97326a205e77e7e1043b75a5cc53f/packages/labs/ssr/src/lib/render-value.ts#L738) ## Testing A test was added to ensure an element with `delegatesFocus` set to true has this attribute properly included in the rendered static markup. --- packages/integrations/lit/server.js | 6 +++++- packages/integrations/lit/test/server.test.js | 11 +++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/integrations/lit/server.js b/packages/integrations/lit/server.js index da571466f498..aa91d1ea8c65 100644 --- a/packages/integrations/lit/server.js +++ b/packages/integrations/lit/server.js @@ -62,7 +62,11 @@ function* render(Component, attrs, slots) { yield `>`; const shadowContents = instance.renderShadow({}); if (shadowContents !== undefined) { - yield '