fix: Always add @astrojs/image to vite.ssr.noExternal #3869
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3820
Changes
Updates the image integration to make sure it's always added to
vite.ssr.noExternal
Why?
Astro scrubs project dependencies to find the common Astro packages, but in an npm workspace it may fail to find the dependency's
package.json
higher up in the project's rootAdding this one-off quick fix here for images, it may be worth a separate PR if there's a good general solution to walk up the tree checking other
node_module
directoriesTesting
Manually tested against the repro project from #3820
Docs
Bug fix only