Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve serverEntrypoint codegen #12566

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve serverEntrypoint codegen #12566

wants to merge 2 commits into from

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 29, 2024

Changes

Remove vitePluginFileURL as it's now builtin to Vite 6. Also updated renderer.serverEntrypoint code generation to be more robust. I've found these improvements from debugging #12556, but it does not fix it yet. I'll send a separate PR in Vite to fix that issue instead.

Testing

Existing tests should pass

Docs

n/a. refactors.

Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: 4af81d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 29, 2024
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's another here

Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #12566 will not alter performance

Comparing remove-fileurl-handling (4af81d4) with main (c50882d)

Summary

✅ 6 untouched benchmarks

@bluwy
Copy link
Member Author

bluwy commented Nov 29, 2024

Looks like removing the fileurl handling caused other issues. Gonna revert that for now and fix the codegen stuff only.

@bluwy bluwy changed the title Remove fileurl handling Improve serverEntrypoint codegen Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants