fix: use path for renderer entrypoint #12563
Closed
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#12533 changed the MDX entrypoint to a URL, so that it could be resolved correctly. However this introduced a different bug that meant the entrypoint could not be resolved in dev if there was a space in the path. It's unclear whether this is a Vite bug or ours, but we can fix it by using
fileURLToPath
instead of passing the URL directly. This PR converts any entrypoint URLs to paths.Fixes #12556
Testing
This is hard to test in the monorepo, because it needs a space in the path to the integration not the site. I tested it by renaming my monorepo folder, but I couldn't work out an easy way to do a test fixture for it.
Docs