Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on path-to-regexp #11981

Closed

Conversation

uwej711
Copy link
Contributor

@uwej711 uwej711 commented Sep 12, 2024

Changes

  • This change removes the path-to-regexp dependency since only a small part of that code was used and that could be implemented quite simple without the dependency.

Testing

The existing tests already cover the changed code so there was no need to add additional tests.

Docs

This is a purely internal change and there will be no change for the users visible.

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 8f3c6ca

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 12, 2024
@uwej711
Copy link
Contributor Author

uwej711 commented Sep 13, 2024

Closing this since the target branch is wrong. Please see #11983

@uwej711 uwej711 closed this Sep 13, 2024
@bluwy
Copy link
Member

bluwy commented Sep 13, 2024

The next branch are for breaking changes and for the next major. Does this bring a breaking change? If so, maybe you can describe the breaking change in the other PR. If not, I think main would be better as presumably we want to fix the vulnerability exposure in stable as soon as possible.

@uwej711
Copy link
Contributor Author

uwej711 commented Sep 13, 2024

@bluwy I created a changeset of type minor and here the pipeline complained about not being able to merge so I just thought next might be the right branch ... so I will try again against main. Thanks.

@uwej711 uwej711 deleted the feature/remove-path-to-regexp-dependnecy branch September 13, 2024 09:08
@bluwy
Copy link
Member

bluwy commented Sep 13, 2024

The merge warning is so that we don't accidentally merge minors when we're not ready to release minors yet. But for this change, a patch should be fine as it doesn't affect users directly.

@uwej711
Copy link
Contributor Author

uwej711 commented Sep 13, 2024

OK will change to patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants