Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapter features messaging #11773

Merged
merged 3 commits into from
Aug 20, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/long-months-burn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Changes the phrasing of the adapter features because they were misleading.
ematipico marked this conversation as resolved.
Show resolved Hide resolved
6 changes: 3 additions & 3 deletions packages/astro/src/integrations/features-validation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,20 +124,20 @@ function validateSupportKind(
}

function featureIsUnsupported(adapterName: string, logger: Logger, featureName: string) {
logger.error('config', `The feature "${featureName}" is not supported (used by ${adapterName}).`);
logger.error('config', `The adapter ${adapterName} doesn't support the feature "${featureName}" yet.`);
ematipico marked this conversation as resolved.
Show resolved Hide resolved
}

function featureIsExperimental(adapterName: string, logger: Logger, featureName: string) {
logger.warn(
'config',
`The feature "${featureName}" is experimental and subject to change (used by ${adapterName}).`,
`The adapter ${adapterName} set experimental support for "${featureName}", which means that things might not work, or could change.`,
ematipico marked this conversation as resolved.
Show resolved Hide resolved
);
}

function featureIsDeprecated(adapterName: string, logger: Logger, featureName: string) {
logger.warn(
'config',
`The feature "${featureName}" is deprecated and will be removed in the future (used by ${adapterName}).`,
`The adapter ${adapterName} has deprecated its support for "${featureName}", which means that the feature might not work anymore in the future for this adapter.`,
ematipico marked this conversation as resolved.
Show resolved Hide resolved
);
}

Expand Down
Loading