feat(toolbar): Allow every element to have every color #10186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 86e84f4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
⚖️ Bundle Size CheckLatest commit: d241e03
|
bluwy
approved these changes
Feb 29, 2024
natemoo-re
reviewed
Feb 29, 2024
There was a problem hiding this comment.
Looks great! I worry about users accidentally passing incorrect attribute values, then losing the element because everything is invisible, so validation would be nice to have, but maybe not that critical.
Also, we have a blue palette if you want to expose that option too! Base is #3645D9, light is #BDC3FF, and dark is #0B1466.
packages/astro/src/runtime/client/dev-toolbar/ui-library/badge.ts
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Mar 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously only a few elements could have different colors, buttons and badges. This PR makes it so every element can be customized in the same fashion. Additionally, it is now fully reactive, so you can change it at runtime however you want.
A notable exception however is Tooltip, because that one doesn't use standard colors and need a bit more design work.
(the card in this screenshot are all hovered, their neutral state has no colors.)
Testing
We don't really test the precise style of everything at this time, nonetheless everything should be clickable and everything like before, so tests should pass!
Docs
withastro/docs#7191