Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic routes take precedence over index.astro in 4.2 #9724

Closed
1 task
whatthewhat opened this issue Jan 18, 2024 · 1 comment · Fixed by #9726
Closed
1 task

Dynamic routes take precedence over index.astro in 4.2 #9724

whatthewhat opened this issue Jan 18, 2024 · 1 comment · Fixed by #9726
Assignees
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) pkg: astro Related to the core `astro` package (scope)

Comments

@whatthewhat
Copy link

whatthewhat commented Jan 18, 2024

Astro Info

Astro                    v4.2.0
Node                     v18.17.0
System                   macOS (arm64)
Package Manager          pnpm
Output                   server
Adapter                  none
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

I've hit a potentially breaking change when updating from 3.5.5 to 4.2.0: [...dynamic].astro routes seem to have higher priority than index.astro after the upgrade. Apologies if this is an expected change, but I was unable to find
it in the changelog.

There is a minimal stackblitz reproduction - with 3.x this would have rendered the Index page.

What's the expected result?

In the stackblitz example I would expect the Index page to be rendered, but instead the dynamic route is rendered.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-pqgx5b?file=src%2Fpages%2F%5B...dynamic%5D.astro

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jan 18, 2024
@Fryuni
Copy link
Member

Fryuni commented Jan 18, 2024

Hey, thanks for the report. There was a patch to define an edge case on the routing, but it shouldn't have affected this use case, so it is indeed a bug.

I'm looking into it

@florian-lefebvre florian-lefebvre added - P4: important Violate documented behavior or significantly impacts performance (priority) - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) and removed needs triage Issue needs to be triaged - P4: important Violate documented behavior or significantly impacts performance (priority) labels Jan 18, 2024
@ematipico ematipico added the pkg: astro Related to the core `astro` package (scope) label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants