Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadableStream in response body not canceled when client closes connection (in dev mode) #9698

Closed
1 task
ruohki opened this issue Jan 15, 2024 · 0 comments · Fixed by #9971
Closed
1 task

ReadableStream in response body not canceled when client closes connection (in dev mode) #9698

ruohki opened this issue Jan 15, 2024 · 0 comments · Fixed by #9971
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: dev Related to `astro dev` CLI command (scope)

Comments

@ruohki
Copy link

ruohki commented Jan 15, 2024

Astro Info

> [email protected] astro
> astro info

Astro                    v4.1.2
Node                     v18.16.1
System                   Windows (x64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/tailwind

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Piggybacking on this #9068 closed issue. The core problem persists on astro dev. Seems to be handled properly when running off the node standalone ssr adapter. But in dev mode keeps ramping up connections.

What's the expected result?

ReadableStream being closed for proper cleanup

Link to Minimal Reproducible Example

#9068

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Jan 15, 2024
@florian-lefebvre florian-lefebvre added - P3: minor bug An edge case that only affects very specific usage (priority) feat: dev Related to `astro dev` CLI command (scope) and removed needs triage Issue needs to be triaged labels Jan 15, 2024
@mingjunlu mingjunlu mentioned this issue Feb 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P3: minor bug An edge case that only affects very specific usage (priority) feat: dev Related to `astro dev` CLI command (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix an issue where ReadableStream wasn't canceled in dev mode
2 participants
@ruohki @florian-lefebvre