Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering when redirecting on astro website deployed to GitHub Pages #9662

Closed
1 task
gregorobreza opened this issue Jan 11, 2024 · 6 comments
Closed
1 task
Labels
needs triage Issue needs to be triaged

Comments

@gregorobreza
Copy link

gregorobreza commented Jan 11, 2024

Astro Info

Astro                    v4.1.2
Node                     v18.18.0
System                   macOS (arm64)
Package Manager          pnpm
Output                   static
Adapter                  none
Integrations             none

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When configured redirection in astro.config.mjs there is a short flickering noticed on live website deployed to GitHub Pages. It works perfectly fine locally.

What's the expected result?

Redirections should happen seamlessly same as when developing locally.

Link to Minimal Reproducible Example

Deployed page:
https://gregorobreza.github.io/astro-redirect-issue/

GitHub repo:
https://github.com/gregorobreza/astro-redirect-issue

Participation

  • I am willing to submit a pull request for this issue.
@ematipico
Copy link
Member

Hi @gregorobreza , can you provide a reproduction with the source code?

@ematipico ematipico added needs repro Issue needs a reproduction and removed needs triage Issue needs to be triaged labels Jan 11, 2024
Copy link
Contributor

Hello @gregorobreza. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

@gregorobreza
Copy link
Author

gregorobreza commented Jan 11, 2024

Sure updated issue description with GithHub repo @ematipico

@ematipico ematipico added needs triage Issue needs to be triaged and removed needs repro Issue needs a reproduction labels Jan 11, 2024
@Princesseuh
Copy link
Member

I'd be happy to be proved wrong, but I don't think there's really a way to fix this, on GitHub Pages the only way to do a redirect is through a meta tag, which is what we use.

We could maybe allow a custom templates for redirect pages so that people can customize it at least

@ematipico
Copy link
Member

Yes, that's how redirects via HTML files work. That's the expected behaviour. Closing.

@ematipico ematipico closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@ematipico
Copy link
Member

We could maybe allow a custom templates for redirect pages so that people can customize it at least

Sounds like good material for an improvement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

3 participants