Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[astrojs/netlify] generated adapter config should use @astrojs/netlify import #9459

Closed
1 task done
Skn0tt opened this issue Dec 18, 2023 · 3 comments · Fixed by #9461
Closed
1 task done

[astrojs/netlify] generated adapter config should use @astrojs/netlify import #9459

Skn0tt opened this issue Dec 18, 2023 · 3 comments · Fixed by #9461
Labels
needs triage Issue needs to be triaged

Comments

@Skn0tt
Copy link
Contributor

Skn0tt commented Dec 18, 2023

Astro Info

n/a

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When running npx astro add netlify, the generated code uses the @astrojs/netlify/functions import. This deprecated with v4 of the adapter.

What's the expected result?

It should use the @astrojs/netlify import instead.

Link to Minimal Reproducible Example

n/a

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 18, 2023
@jacobdalamb
Copy link
Contributor

jacobdalamb commented Dec 18, 2023

This sounds correct per the docs, the Netlify example page, and release notes for v3.0 @astrojs/[email protected].

@Skn0tt Skn0tt changed the title [astrojs/netlify] [astrojs/netlify] generated adapter config should use @astrojs/netlify import Dec 18, 2023
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Dec 18, 2023

We've published v4 this morning, which deprecated it in favour of the @astrojs/netlify import: https://github.com/withastro/adapters/blob/e21ffd29edd63d7f9d7024071f5e933f433a5686/packages/netlify/src/functions.ts#L4-L6

@jacobdalamb
Copy link
Contributor

We've published v4 this morning, which deprecated it in favour of the @astrojs/netlify import: withastro/adapters@e21ffd2/packages/netlify/src/functions.ts#L4-L6

Oh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants