Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build after @astrojs/[email protected]: Could not resolve "./vnode-children.js" #8135

Closed
1 task
xriter opened this issue Aug 18, 2023 · 2 comments · Fixed by #8137, #8149 or #8228
Closed
1 task
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) pkg: react Related to React (scope)

Comments

@xriter
Copy link

xriter commented Aug 18, 2023

What version of astro are you using?

2.10.10

Are you using an SSR adapter? If so, which one?

Node

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

Safari

Describe the Bug

When trying to npm run build the error Could not resolve "./vnode-children.js" from "node_modules/@astrojs/react/server.js" gets thrown.

Scherm­afbeelding 2023-08-18 om 16 53 19

When using:

// astro.config.mjs
import { defineConfig } from 'astro/config';
import node from '@astrojs/node';
import react from '@astrojs/react';

export default defineConfig({
  output: 'server',
  adapter: node({
    mode: 'standalone',
  }),
  integrations: [react()],
});
// package.json
...
"dependencies": {
    "@astrojs/node": "^5.3.4",
    "@astrojs/react": "^2.3.0",
    "astro": "^2.10.10"
  }
...

The problem seems to be in the upgrade from @astrojs/[email protected] to @astrojs/[email protected].
When building with [email protected] with @astrojs/[email protected], it works.

What's the expected result?

A successful build.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-tncfye?file=astro.config.mjs

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Aug 18, 2023
@xriter xriter changed the title Can't build Astro 2.10.10 with Node and React: Could not resolve "./vnode-children.js" Can't build after @astrojs/[email protected]: Could not resolve "./vnode-children.js" Aug 18, 2023
@natemoo-re natemoo-re added the - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Aug 18, 2023
@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Aug 18, 2023
@lilnasy lilnasy mentioned this issue Aug 18, 2023
1 task
@lilnasy
Copy link
Contributor

lilnasy commented Aug 18, 2023

Still happens on 2.3.1

image

@lilnasy lilnasy reopened this Aug 18, 2023
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Aug 18, 2023
@lilnasy lilnasy added pkg: react Related to React (scope) and removed needs triage Issue needs to be triaged labels Aug 18, 2023
@olibos
Copy link

olibos commented Aug 23, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) pkg: react Related to React (scope)
Projects
None yet
4 participants