Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.0-beta.1] Build and dev fails with missing collapseDuplicateSlashes export #8052

Closed
1 task
fflaten opened this issue Aug 13, 2023 · 3 comments · Fixed by #8067
Closed
1 task

[3.0.0-beta.1] Build and dev fails with missing collapseDuplicateSlashes export #8052

fflaten opened this issue Aug 13, 2023 · 3 comments · Fixed by #8067
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)

Comments

@fflaten
Copy link
Contributor

fflaten commented Aug 13, 2023

What version of astro are you using?

3.0.0-beta.1

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

pnpm (also failed with npm)

What operating system are you using?

Linux

What browser are you using?

N/A

Describe the Bug

build and dev fails with the latest beta. Only changed from beta.0 to beta.1.

$ pnpm build

> @fflaten/[email protected] build /workspaces/Website
> astro build

 error   The requested module '../core/path.js' does not provide an export named 'collapseDuplicateSlashes'
file:///workspaces/Website/node_modules/.pnpm/[email protected]_@[email protected][email protected][email protected]/node_modules/astro/dist/vite-plugin-astro-server/request.js:5
import { collapseDuplicateSlashes, removeTrailingForwardSlash } from "../core/path.js";
         ^^^^^^^^^^^^^^^^^^^^^^^^
SyntaxError: The requested module '../core/path.js' does not provide an export named 'collapseDuplicateSlashes'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)
 ELIFECYCLE  Command failed with exit code 1.

What's the expected result?

Build should work.

Link to Minimal Reproducible Example

3.0 not compatible with Stackblitz

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Aug 13, 2023
@fflaten fflaten changed the title [3.0.0-beta.1] Build and dev fails due to missing collapseDuplicateSlashes export [3.0.0-beta.1] Build and dev fails with missing collapseDuplicateSlashes export Aug 13, 2023
@bluwy bluwy added - P4: important Violate documented behavior or significantly impacts performance (priority) needs triage Issue needs to be triaged and removed needs triage Issue needs to be triaged labels Aug 14, 2023
@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Aug 14, 2023
@bluwy
Copy link
Member

bluwy commented Aug 14, 2023

Looks like it's because that feature got mixed up during rebases for the @astrojs/internal-helpers package. We'd need to re-release it.

@natemoo-re
Copy link
Member

natemoo-re commented Aug 14, 2023

Should be closed by #8067

This was linked to pull requests Aug 14, 2023
@natemoo-re natemoo-re removed a link to a pull request Aug 14, 2023
@natemoo-re
Copy link
Member

Confirmed that this is fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants