Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[astrojs/cloudflare] use Astro.locals for env variable #7538

Closed
1 task done
alexanderniebuhr opened this issue Jun 30, 2023 · 2 comments · Fixed by #7541
Closed
1 task done

[astrojs/cloudflare] use Astro.locals for env variable #7538

alexanderniebuhr opened this issue Jun 30, 2023 · 2 comments · Fixed by #7541
Assignees
@alexanderniebuhr
Labels
feat: ssr Related to SSR (scope)

Comments

@alexanderniebuhr
Copy link
Member

alexanderniebuhr commented Jun 30, 2023 •
edited
Loading

  • updating cloudflare so that it's "env" is available on Astro.locals
  • should be available in pages via Astro.locals.env
  • Which means you don't have to do getRuntime() any more

Participation

  • I am willing to submit a pull request for this issue.
@alexanderniebuhr
Copy link
Member Author

👋 i'm working on this

@alexanderniebuhr alexanderniebuhr mentioned this issue Jun 30, 2023
Merged
@alexanderniebuhr
Copy link
Member Author

just figured that we need to expose runtime in addition to keep feature parity with getRuntime()

@Princesseuh Princesseuh added the feat: ssr Related to SSR (scope) label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderniebuhr alexanderniebuhr

Labels
feat: ssr Related to SSR (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(@astrojs/cloudfalre): add cloudflare envs to Astro.locals
3 participants
@ematipico @Princesseuh @alexanderniebuhr