Can't set cookies in middleware

[xriter]

What version of astro are you using?

2.5.6

Are you using an SSR adapter? If so, which one?

Node

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

Reading cookies context.cookies.get(...) from middleware.ts works fine, but when trying to set a cookie context.cookies.set(...), it doesn't seem to work.

// middleware.ts
import type { AstroCookies } from "astro";

export async function onRequest({ cookies }, next) {
	(cookies as AstroCookies).set("cookieFromMiddleware", "doesntWork", {
		path: "/",
		expires: new Date(Date.now() + 1000 * 60 * 60 * 24 * 365),
	});

	return next();
}

Setting a cookie (using Astro.cookies) in a .astro file does seem to work fine.

Am I missing something, or is this a bug?

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-tgbzvq?file=src%2Fmiddleware.ts

Participation

• I am willing to submit a pull request for this issue.

[matthewp]

I think this is a bug. Probably we are creating a new instance of AstroCookies when the page is rendered, wiping out your previous sets.

Btw, why the (cookies as AstroCookies)? Is that incorrectly typed?

[xriter]

@matthewp It was set to AstroCookies because I don't know what type to use for the onRequest function. If I know that, then hopefully the cookies will get the correct type automatically?

[i7N3]

@matthewp

I am faced with the fact that the cookie is being lost.

"astro": "2.6.1"
"@astrojs/node": "5.2.0"

How to reproduce?

const middleware = defineMiddleware(async (context, next) => {
        // ...
	if (isAuthSuccess) {
		context.cookies.set('jid', '<TOKEN>')
		return context.redirect(`/dashboard`)
	}
	return next()
})
export const onRequest = sequence(middleware)

When I log cookie value on /dashboard page with Astro.cookies.get(...).value it's empty.
If I remove the redirect statement, then it works.

[i7N3]

Here is the reproduction: https://github.com/i7N3/astro-middleware-bug-reproduction
Node: 16.18.0 (nvm), Monterey m1, tested both: dev and preview

[i7N3]

@matthewp Should I open a new Issue?

[matthewp]

Yes, please do, thanks!