Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide type for the default ASSETS_PREFIX env var #7164

Closed
1 task done
ohansemmanuel opened this issue May 22, 2023 · 1 comment · Fixed by #7172
Closed
1 task done

Provide type for the default ASSETS_PREFIX env var #7164

ohansemmanuel opened this issue May 22, 2023 · 1 comment · Fixed by #7172
Assignees
@Princesseuh

Comments

@ohansemmanuel
Copy link

What version of astro are you using?

2.4.5

Are you using an SSR adapter? If so, which one?

NO

What package manager are you using?

npm

What operating system are you using?

Mac

What browser are you using?

Chrome

Describe the Bug

It might be worth updating the type definition to include ASSETS_PREFIX.
See https://github.com/withastro/astro/blob/main/packages/astro/import-meta.d.ts#L30

CleanShot 2023-05-22 at 18 18 31@2x

Link to Minimal Reproducible Example

NA

Participation

  • I am willing to submit a pull request for this issue.
@ohansemmanuel
Copy link
Author

FWIW, is SSR a default env var? It doesn't seem to be mentioned in the docs

@Princesseuh Princesseuh self-assigned this May 23, 2023
@Princesseuh Princesseuh mentioned this issue May 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Princesseuh Princesseuh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add types for import.meta.env.ASSETS_PREFIX and import.meta.env.SITE withastro/astro
2 participants
@Princesseuh @ohansemmanuel