@astrojs/rss Typescript error for pagesGlobToRssItems when using strictest tsconfig

[aivarsliepa]

What version of astro are you using?

2.1.2

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Windows

What browser are you using?

Chrome

Describe the Bug

@astrojs/rss version 2.3.0

This affects only code editor. CLI build still passes.

By using Typescript with strictest tsconfig for RSS generation (rss.xml.ts instead of rss.xml.js), there is a type error just by using code from the official tutorial and docs.

Problem is that return type from resolved pagesGlobToRssItems() does not satisfy RSSOptions.items.
Apparently it's because of exactOptionalPropertyTypes: true tsconfig flag.
RSSFeedItem.content type is content?: string; and corresponding part of return type of pagesGlobToRssItems is content?: string | undefined.

If I modify RSSFeedItem.content type in @astrojs/rss/dist/index.d.ts to content?: string | undefined, the error goes away.

import rss, { pagesGlobToRssItems } from "@astrojs/rss";

export async function get() {
  return rss({
    title: "Astro Learner | Blog",
    description: "My journey learning Astro",
    site: "https://my-blog-site.netlify.app",
    items: await pagesGlobToRssItems(import.meta.glob("./**/*.md")),
    customData: `<language>en-us</language>`,
  });
}

Type '{ description?: string | undefined; customData?: string | undefined; draft?: boolean | undefined; content?: string | undefined; title: string; pubDate: Date; link: string; }[]' is not assignable to type 'Record<string, (...args: unknown[]) => Promise<any>> | RSSFeedItem[]'.
  Type '{ description?: string | undefined; customData?: string | undefined; draft?: boolean | undefined; content?: string | undefined; title: string; pubDate: Date; link: string; }[]' is not assignable to type 'RSSFeedItem[]'.
    Type '{ description?: string | undefined; customData?: string | undefined; draft?: boolean | undefined; content?: string | undefined; title: string; pubDate: Date; link: string; }' is not assignable to type 'RSSFeedItem' with 'exactOptionalPropertyTypes: true'. Consider adding 'undefined' to the types of the target's properties.
      Types of property 'content' are incompatible.
        Type 'string | undefined' is not assignable to type 'string'.
          Type 'undefined' is not assignable to type 'string'.ts(2322)
index.d.ts(16, 5): The expected type comes from property 'items' which is declared here on type 'RSSOptions'

Link to Minimal Reproducible Example

https://stackblitz.com/edit/node-h2jxcq?file=src%2Fpages%2Frss.xml.ts

Participation

• I am willing to submit a pull request for this issue.

[bluwy]

If I modify RSSFeedItem.content type in @astrojs/rss/dist/index.d.ts to content?: string | undefined, the error goes away.

That sounds good to me. Feel free to send a PR if you'd like!