You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Might be a good idea to add a comment above mentioning nodejs/node#42787 as @types/node declarations don't reflect this old bug.
Link to Minimal Reproducible Example
Participation
I am willing to submit a pull request for this issue.
The text was updated successfully, but these errors were encountered:
zEh-
changed the title
CLI arg --host works for "dev" but not for "preview" (on Node >=18.10)
CLI arg --host displays network ip for "dev" but not for "preview" (on Node >=18.10)
Nov 5, 2022
What version of
astro
are you using?1.6.3
Are you using an SSR adapter? If so, which one?
None
What package manager are you using?
npm
What operating system are you using?
Windows
Describe the Bug
Expected
Actual
Cause
Manual version comparison is flawed here.
The current code
nodeVersion >= 18.4
wrongly results for LTS in18.12 >= 18.4
beingfalse
.This should suffice:
Semver seems overkill:
Might be a good idea to add a comment above mentioning nodejs/node#42787 as @types/node declarations don't reflect this old bug.
Link to Minimal Reproducible Example
Participation
The text was updated successfully, but these errors were encountered: