Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@astrojs/image] images should be built to dist/assets #4677

Closed
1 task done
tony-sull opened this issue Sep 8, 2022 · 0 comments · Fixed by #4678
Closed
1 task done

[@astrojs/image] images should be built to dist/assets #4677

tony-sull opened this issue Sep 8, 2022 · 0 comments · Fixed by #4678
Assignees
@tony-sull
Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) pkg: image Related to the `@astrojs/image` package (scope)

Comments

@tony-sull
Copy link
Contributor

What version of astro are you using?

1.0.7

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

pnpm

What operating system are you using?

mac

Describe the Bug

Optimized images built for SSG builds are being dropped in the main dist directory, they should go into dist/assets along side other static assets built by Vite

Link to Minimal Reproducible Example

https://github.com/withastro/www-2

Participation

  • I am willing to submit a pull request for this issue.
@tony-sull tony-sull added - P4: important Violate documented behavior or significantly impacts performance (priority) s1-small pkg: image Related to the `@astrojs/image` package (scope) labels Sep 8, 2022
@tony-sull tony-sull self-assigned this Sep 8, 2022
@tony-sull tony-sull mentioned this issue Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tony-sull tony-sull

Labels
- P4: important Violate documented behavior or significantly impacts performance (priority) pkg: image Related to the `@astrojs/image` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[@astrojs/image] Build all optimized images to dist/assets withastro/astro
1 participant
@tony-sull